Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes the fastbinary module optional for the e6data Python connector and adds support for custom SSL certificates. The main changes allow users to run the connector in environments where system dependencies for fastbinary cannot be installed, with an option to fall back to pure Python implementation. Additionally, users can now provide custom CA certificates for HTTPS connections through HAProxy.
Key Changes:
- Made
fastbinarymodule optional with arequire_fastbinaryflag - Added
ssl_certparameter to support custom SSL certificates - Updated version from 2.3.11 to 2.3.12
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Version bump to 2.3.12 |
| e6data_python_connector/e6data_grpc.py | Added ssl_cert and require_fastbinary parameters with SSL credential handling and fastbinary availability checking |
| e6data_python_connector/datainputstream.py | Converted fastbinary import from required to optional with availability checking function |
| e6data_python_connector/cluster_manager.py | Added ssl_cert parameter and SSL credential handling for cluster manager |
| README.md | Updated documentation with examples for SSL certificates and fastbinary handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.