Ruff rules for comprehensions and performance#329
Merged
aaronliu0130 merged 2 commits intodevelopfrom Mar 11, 2025
Merged
Conversation
bfa7806 to
13c4725
Compare
jayvdb
reviewed
Mar 8, 2025
cpplint.py
Outdated
Member
There was a problem hiding this comment.
double space at "_USAGE " - odd that ruff isnt picking that up
Member
Author
There was a problem hiding this comment.
This will be automatically fixed when we add ruff format to pre-commit.
19ec1b4 to
c2afaa7
Compare
c2afaa7 to
b181eaa
Compare
Member
Author
|
Reviews please. |
aaronliu0130
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
%
ruff check --select=C4,PERF --output-format=concise