Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unit tests that are executed upon a push/PR are vital to ensure a successful continuous development of the code. This of course requires the same software environment to ensure realistic testing conditions.
Currently, each of the jobs in the github action workflow creates the software stack every time the job is executed. Since multiple jobs can share a software environment and the software stack itself doesn't change with every PR, this is not the most effective way to go about this.
This (draft) PR introduces the concept of caching part of the data for repeated use. It provides a very preliminary implementation with a lot of code repetition at the moment, but can be seen as a proof of concept already imho. Things that need to be investigated in the scope of this PR
This PR has undergone a significant amount of changes during it's life time. @dsavoiu was kind enough to summarize the current set of changes - thanks again, and sorry that I didn't do this in the first place! It's much appreciated :)
For reference and to facilitate future reviews, let me summarize what I believe to be the main changes introduced by this PR (feel free to supplement this list in case I forgot anything and/or add this information to the PR description):
Any suggestions are of course very welcome!