Fix: Handle unparseable expires_at by falling back to expires_in#840
Closed
ShaikAyesha17 wants to merge 1 commit intoauthlib:mainfrom
Closed
Fix: Handle unparseable expires_at by falling back to expires_in#840ShaikAyesha17 wants to merge 1 commit intoauthlib:mainfrom
ShaikAyesha17 wants to merge 1 commit intoauthlib:mainfrom
Conversation
Fixes authlib#833 When an OAuth2/OIDC server returns expires_at as a string that cannot be parsed as an integer, the OAuth2Token initialization now gracefully handles the ValueError/TypeError and falls back to using expires_in to calculate the expiration time. This prevents token creation from failing when expires_at is in a non-standard format while expires_in is available.
Contributor
|
I have a PR w/ proper formatting, tests, etc here: #842 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #833
When an OAuth2/OIDC server returns expires_at as a string that cannot be parsed as an integer, the OAuth2Token initialization now gracefully handles the ValueError/TypeError and falls back to using expires_in to calculate the expiration time.
This prevents token creation from failing when expires_at is in a non-standard format while expires_in is available.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
prek.pragma: no cover