Skip to content

Conversation

@azmeuk
Copy link
Member

@azmeuk azmeuk commented Aug 25, 2025

What kind of change does this PR introduce?

The behavior to find the alg with which the id_token is signed is:

  • use alg is set in get_jwt_config if defined
  • else use client.id_token_signed_response_alg if defined
  • else use the default RS256

I think client.id_token_signed_response_alg should take precedence over get_jwt_config, but that would be a breaking change. I will open another ticket for that, this could target v1.8.

Working on this part of the code made me realize that he get_jwt_config might be a little outdated. We would probably want use get_server_jwks instead here, instead of manually passing a key. What do you think?

fixes #755

Checklist

  • You ran the linters with pre-commit.
  • You wrote unit test to demonstrate the bug you are fixing, or to stress the feature you are bringing.

  • You consent that the copyright of your pull request source code belongs to Authlib's author.

@azmeuk azmeuk requested a review from lepture August 25, 2025 14:49
@azmeuk azmeuk force-pushed the 755-idtoken-metadata branch from 8665d3f to 86b1b78 Compare August 25, 2025 15:02
@lepture lepture merged commit bc71165 into authlib:main Aug 26, 2025
8 checks passed
@azmeuk azmeuk deleted the 755-idtoken-metadata branch August 26, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use the client metadata id_token_signed_response_alg to sign the id_token

2 participants