TST: autofixes for FURB110 (if-exp-instead-of-or-operator)#19263
TST: autofixes for FURB110 (if-exp-instead-of-or-operator)#19263pllim merged 1 commit intoastropy:mainfrom
FURB110 (if-exp-instead-of-or-operator)#19263Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
mhvk
left a comment
There was a problem hiding this comment.
Hmm, feels for at least a few of them it should have been replacing if k with if k is not None... This may need some actual thought.
I'm not sure what you mean, but these are not equivalent. I do believe |
|
Slightly more brainpower to parse but less code is good, right? 🎲 |
|
I know the code is equivalent; my point was really that I think in a few cases the existing code was (subtly) wrong. Anyway, this can be sorted if we ever get the none-aware operators... |
Sounds like a follow-up bug fix PR? |
Description
ref #19261