Fix ClassCastException in SoftAssertions with custom list assertions#4127
Open
HuitaePark wants to merge 1 commit intoassertj:mainfrom
Open
Fix ClassCastException in SoftAssertions with custom list assertions#4127HuitaePark wants to merge 1 commit intoassertj:mainfrom
HuitaePark wants to merge 1 commit intoassertj:mainfrom
Conversation
Changed `containsExactlyInAnyOrderForProxy` signature to accept Collection instead of arrays. This prevents ClassCastException caused by strict array type checking in proxies. Fixes assertj#3797
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified
containsExactlyInAnyOrderForProxyto accept aCollectioninstead of arrays. This preventsClassCastExceptioncaused by strict array type checking in proxies.ForProxymethod now takesCollection.IterableUtil.toArrayListfor safe conversion.SoftAssertions_proxied_AbstractListAssert_Testto verify the fix.I have applied this fix only to
containsExactlyInAnyOrderas a proof of concept.Please confirm if this direction is correct. Once approved, I will apply this pattern to all other affected methods (e.g.,
ForProxy).Check List: