Replace simple date format by date time formatter#3483
Open
joel-costigliola wants to merge 2 commits intomainfrom
Open
Replace simple date format by date time formatter#3483joel-costigliola wants to merge 2 commits intomainfrom
joel-costigliola wants to merge 2 commits intomainfrom
Conversation
…TE_TIME, ISO_LOCAL_DATE_TIME, ISO_LOCAL_DATE DateTimeFormatter and Timestamp parsing as supported by Timestamp.valueOf(String). Fix #3482
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
301ca01 to
c730d18
Compare
b6e46b9 to
3f3b814
Compare
b2b071f to
2dab02c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3482
The only bit that was not addressed is the lenient parsing, this is why the tests are failing.
At least we are now supporting nanos, ex:
Not supporting lenient date parsing is breaking change, probably one we can remove in AssertJ 4 since it's not a great idea to accept date like
2001-01-34anyway.