SemanticHighlighter support for context sensitive value keyword#9079
Merged
mbien merged 2 commits intoapache:masterfrom Dec 17, 2025
Merged
SemanticHighlighter support for context sensitive value keyword#9079mbien merged 2 commits intoapache:masterfrom
mbien merged 2 commits intoapache:masterfrom
Conversation
mbien
commented
Dec 11, 2025
Comment on lines
987
to
991
| Token<?> t = firstIdentifierToken("permits");// NOI18N | ||
| if (tl != null) { | ||
| if (t != null) { | ||
| contextKeywords.add(t); | ||
| scan(permitList, null); | ||
| } |
Contributor
matthiasblaesing
left a comment
There was a problem hiding this comment.
I only eyeballed this, but looks good. Thank you.
works only when combined with a valhalla build of javac
Member
Author
|
just a rebase for new dev build |
Member
Author
|
manual test worked, added instructions under the issue #8994 (comment) thanks for review, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
works only when combined with a valhalla build of javac (e.g: uninstall nb-javac and run a NB dev build on the valhalla build, see #8994 (comment))
Thats also why there is no unit test.
The other commit is code cleanup in the
semanticpackage.