Improving handling of broken bootpaths with an implicit hardcoded --release#9048
Merged
lahodaj merged 1 commit intoapache:masterfrom Dec 1, 2025
Merged
Conversation
mbien
approved these changes
Nov 29, 2025
Member
mbien
left a comment
There was a problem hiding this comment.
looks good to me
(some of the javac flags this class sets might no longer be supported? e.g i could still find -XDsuppressAbortOnBadClassFile in the jdk 8 repo but no longer in jdk 11)
java/java.source.base/src/org/netbeans/modules/java/source/parsing/JavacParser.java
Outdated
Show resolved
Hide resolved
c83545f to
e409a3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a project sends broken bootclasspath/system module path, NetBeans'
JavacParserwill fall back to an implicit--release. while I may have some reservations about it, it does help in some cases.There are two problems with that however:
--limit-modulesare usually filtered-out, as the validated source level is something extremely old (like1.3). If we use the implicit--release, we should validate against it.--releasewon't be used when very old source level is used. The proposal herein is to simply use the oldest supported source level.^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)