Enable multiview for XJB (JAXB customization files)#9030
Enable multiview for XJB (JAXB customization files)#9030matthiasblaesing merged 1 commit intoapache:masterfrom
Conversation
java/xml.jaxb/nbproject/project.xml
Outdated
| </run-dependency> | ||
| </dependency> | ||
| <dependency> | ||
| <code-name-base>org.netbeans.api.progress.nb</code-name-base> |
There was a problem hiding this comment.
is there a reason for adding progress.nb? I think all it uses is ProgressHandle which is org.netbeans.api.progress
There was a problem hiding this comment.
I used the "search for dependency" feature. Might have added that.
There was a problem hiding this comment.
ah I see. If I understood it correctly, there was an attempt to reduce the surface area of that API and split it in two (pre-apache, see linked commit in #8927).
org.netbeans.api.progress would be the minimal/toolkit independent API. If I see this correctly it would be sufficient for this module since it uses only ProgressHandle and nothing more advanced. I likely forgot to add it as direct dependency to this module since I had to fix some manually.
There was a problem hiding this comment.
(its already a test dependency of xml.jaxb, which can be removed once its a compile dependency)
There was a problem hiding this comment.
Updated in place. I don't plan to do another round.
There was a problem hiding this comment.
well, now you removed it completely which is ok too I suppose ;)
what I tried to explain is that org.netbeans.api.progress.nb could be changed to org.netbeans.api.progress which was introduced as smaller API since https://github.com/emilianbold/netbeans-releases/commit/e7049cf98094ee5f0b7dea02c0c0e43e01e8da98
78269b5 to
89412d1
Compare
Closes: #9008