Skip to content

Comments

Update javac package list in APTUtils#8931

Merged
mbien merged 1 commit intoapache:masterfrom
mbien:update-javac-package-list
Jan 21, 2026
Merged

Update javac package list in APTUtils#8931
mbien merged 1 commit intoapache:masterfrom
mbien:update-javac-package-list

Conversation

@mbien
Copy link
Member

@mbien mbien commented Oct 17, 2025 •
edited
Loading

Saw that list while going through heap dumps and looking through GC roots. Looks important.

Not sure if org.netbeans.lib.nbjavac needs to be on it too or only the original javac packages.

removed

  • com.sun.javadoc
  • com.sun.tools.javadoc
  • com.sun.tools.hc

added

  • com.sun.tools.doclint
  • com.sun.tools.javap

@mbien mbien added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Oct 17, 2025
@mbien mbien requested a review from lahodaj October 17, 2025 17:10
@mbien mbien added this to the NB29 milestone Oct 25, 2025
@mbien
Copy link
Member Author

mbien commented Oct 25, 2025

@lahodaj could you check if this update is ok? I believe that currently some classes may be loaded using the wrong CL since the list misses some packages.

@mbien mbien force-pushed the update-javac-package-list branch from 216db69 to 702d082 Compare December 18, 2025 13:58
@mbien mbien force-pushed the update-javac-package-list branch from 702d082 to cc0828e Compare December 18, 2025 15:49
@mbien
Update javac package list in APTUtils
0fa3d35 
removed
 - com.sun.javadoc
 - com.sun.tools.javadoc
 - com.sun.tools.hc

added
 - com.sun.tools.doclint
 - com.sun.tools.javap
@mbien mbien added the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Jan 20, 2026
@mbien
Copy link
Member Author

mbien commented Jan 20, 2026

gong to rebase this for a fresh dev build

@mbien mbien force-pushed the update-javac-package-list branch from cc0828e to 0fa3d35 Compare January 20, 2026 11:03
mbien
mbien commented Jan 20, 2026
View reviewed changes
java/libs.nbjavacapi/manifest.mf
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/nbjavac/api/Bundle.properties
OpenIDE-Module-Specification-Version: 21.9
OpenIDE-Module-Hide-Classpath-Packages: com.sun.javadoc.**, com.sun.source.**, javax.annotation.processing.**, javax.lang.model.**, javax.tools.**, com.sun.tools.javac.** com.sun.tools.javac.**, com.sun.tools.javadoc.**, com.sun.tools.javap.**, com.sun.tools.classfile.**, com.sun.tools.doclint.**
OpenIDE-Module-Hide-Classpath-Packages: com.sun.source.**, javax.annotation.processing.**, javax.lang.model.**, javax.tools.**, com.sun.tools.javac.**, com.sun.tools.javap.**, com.sun.tools.classfile.**, com.sun.tools.doclint.**
Copy link
Member Author

@mbien mbien Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth noting that a coma was missing in this section: com.sun.tools.javac.** com.sun.tools.javac.**,

@mbien mbien marked this pull request as ready for review January 20, 2026 17:55
@mbien
Copy link
Member Author

mbien commented Jan 21, 2026 •
edited
Loading

planning to merge this for NB 29

compared the paths within the javacapi.jar to the manifest/List values and it looks correct to me after the change.

tree -Ld 4 org-netbeans-libs-javacapi
org-netbeans-libs-javacapi
├── com
│   └── sun
│       ├── source
│       │   ├── doctree
│       │   ├── tree
│       │   └── util
│       └── tools
│           ├── classfile
│           ├── javac
│           └── javap
├── javax
│   ├── annotation
│   │   └── processing
│   ├── lang
│   │   └── model
│   │       ├── element
│   │       ├── type
│   │       └── util
│   └── tools
└── org
    └── netbeans
        └── libs
            └── javacapi

@mbien
Copy link
Member Author

mbien commented Jan 21, 2026

indexer smoke test worked fine. same metaspace totals as without this PR (same graph as #8702).

merging

@mbien mbien merged commit 32ce2bf into apache:master Jan 21, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebarboni ebarboni ebarboni left review comments

@lahodaj lahodaj Awaiting requested review from lahodaj

Assignees

No one assigned

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)

Projects

None yet

Milestone

NB29

Development

Successfully merging this pull request may close these issues.

2 participants

@mbien @ebarboni