Gradle projects should prefer test class name as NB testsuite name#8879
Merged
mbien merged 1 commit intoapache:masterfrom Oct 2, 2025
Merged
Gradle projects should prefer test class name as NB testsuite name#8879mbien merged 1 commit intoapache:masterfrom
mbien merged 1 commit intoapache:masterfrom
Conversation
cdc0ed6 to
4e8e013
Compare
Contributor
Author
|
@mbien I noticed the Java modules checks didn't run, but maybe they should because the change is in |
Member
|
@wrprice my mistake. I set the labels before even looking at the code since i was busy doing something else. Next run (e.g next pr sync, rebase etc) should have the java job too. Good catch! |
Contributor
Author
|
Force-pushed to trigger workflows, no changes. |
mbien
approved these changes
Oct 2, 2025
Member
|
oh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java test support for Gradle was favoring the Gradle test suite name over the test class name, but NB expects that test suites are class names. In the Gradle model, the suite name can be a method name within the test class, or even a Gradle task name (when a test class is absent for the event).
fixes #8878
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)