Conversation
4 tasks
Contributor
Member
Author
|
@matthiasblaesing oh cool thanks! I hoped it would be just about testdata updates when I saw the failures, but didn't had time at that moment when I opened this PR, Will add your changes of course. |
- boot cp getter needed repairs, apart from that most seem to pass Fix tests in web.el: - ELDeclarationFinderTest: Wrong offsets caused by added licenses header fixed (old positions in corresponding code were checked against new positions in todays code) - ELCompletionTest: String gained new methods (cc.attrs.muj is declared String), these need to be reflected. Golden file was regenerated with JDK17 and methods to be checked locked down to JDK17 Co-authored-by: Matthias Bläsing <mblaesing@doppel-helix.eu>
2cbba1a to
afbe271
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
boot cp getter needed repairs, apart from that most seem to be passing
ran it locally about 10 times and they appear to be stable without retry script