Skip to content

Comments

[GITHUB-8296] Adding support for PatternCaseLabel#8714

Merged
ebarboni merged 1 commit intoapache:deliveryfrom
lahodaj:GITHUB-8296
Aug 6, 2025
Merged

[GITHUB-8296] Adding support for PatternCaseLabel#8714
ebarboni merged 1 commit intoapache:deliveryfrom
lahodaj:GITHUB-8296

Conversation

@lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Aug 6, 2025

Prevents a crash when rewriting switch with pattern case labels.

Not sure if this should go to NB27 - feel free to change to master.

closes #8296


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@lahodaj lahodaj added this to the NB27 milestone Aug 6, 2025
@lahodaj lahodaj added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Aug 6, 2025
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing. good NB 27 candidate IMO.

tested the reproducer and refactoring worked

@ebarboni
Copy link
Contributor

ebarboni commented Aug 6, 2025

LGTM merging that for rc3

@ebarboni ebarboni merged commit d328fec into apache:delivery Aug 6, 2025
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants