Merged
Conversation
Contributor
Author
|
@Fokko @syun64 @flyrain @RussellSpitzer |
70ddae2 to
414e91d
Compare
Contributor
Author
|
Requesting for review one this one please. |
flyrain
reviewed
Mar 5, 2024
Contributor
flyrain
left a comment
There was a problem hiding this comment.
LGTM overall. Left a minor suggestion.
Contributor
|
@himadripal Can you fix the issue here? And update the doc in the same PR? Apart from that, this looks good. Thanks for working on this 👍 |
414e91d to
a4492f1
Compare
flyrain
approved these changes
Mar 5, 2024
Contributor
flyrain
left a comment
There was a problem hiding this comment.
+1, left a minor suggestion.
Contributor
Author
Fokko
approved these changes
Mar 6, 2024
Contributor
There was a problem hiding this comment.
Thanks @himadripal for working on this, and thanks @flyrain for the review!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#479
In this PR, I have tried to provision to pass all additional optional parameter, along with audience.