Add analytics block on Pyiceberg website#2587
Conversation
|
Thanks @rambleraptor looks like we need the asf header for the new file |
|
Is it possible for us to turn off the copyright checker on that one file? It seems like a waste for every rendered HTML to include the ASF header just to fulfill this requirement. |
|
yea i noticed the file in the other repo doesnt need the ASF header https://github.com/apache/iceberg/blob/main/site/overrides/main.html we can modify https://github.com/apache/iceberg-python/blob/main/dev/.rat-excludes i think its fine to exclude all of Lines 34 to 50 in ce28e00 @Fokko what do you think? |
|
@kevinjqliu @Fokko added mkdocs/ to .rat-excludes! |
Fokko
left a comment
There was a problem hiding this comment.
Nice, thanks for adding this @rambleraptor 🙌 Thanks for the review @kevinjqliu
Closes #2559
Rationale for this change
This adds the same Matomo script tag found in the Iceberg website to our Python documentation website.
Are these changes tested?
Script tag found when served locally.
Are there any user-facing changes?