fix: correct type mismatch in BinaryEncoder write#2460
Merged
Fokko merged 1 commit intoapache:mainfrom Sep 17, 2025
Merged
Conversation
Fokko
approved these changes
Sep 17, 2025
Contributor
Fokko
left a comment
There was a problem hiding this comment.
Thanks @zhongyujiang for cleaning this up 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Some fsspec write implementations expect the input data to be
bytes, such as in JuiceFS: https://github.com/juicedata/juicefs/blob/main/sdk/python/juicefs/juicefs/juicefs.py#L514.But currently, some places in
BinaryEncoderusebytearray, which can cause exceptions when writing the manifest.I ran into this issue while adding Juice filesystem support, so this PR fixes the data type written by
BinaryEncodertobytesin order to resolve it.Currently,
pyiceberg.io.OutputStream.writeis also annotated to accept data of typebytes.Are these changes tested?
It seems that the filesystems currently supported in pyiceberg do not strictly require the write input to be of type
bytes, so I didn’t add a test. I tested this on our internal Juice filesystem, and it works.Are there any user-facing changes?
No