Refactor PyArrow DataFiles Projection functions#1043
Merged
Fokko merged 7 commits intoapache:mainfrom Aug 20, 2024
Merged
Conversation
kevinjqliu
reviewed
Aug 14, 2024
Contributor
kevinjqliu
left a comment
There was a problem hiding this comment.
Thanks for working on this! I like the overall approach. Added a few comments.
I'm curious what the difference between project_table and project_batches from an API standpoint (and if we should document that)
kevinjqliu
reviewed
Aug 14, 2024
Comment on lines
+1312
to
+1328
| def _fs_from_file_path(file_path: str, io: FileIO) -> FileSystem: | ||
| scheme, netloc, _ = _parse_location(file_path) | ||
| if isinstance(io, PyArrowFileIO): | ||
| return io.fs_by_scheme(scheme, netloc) | ||
| else: | ||
| try: | ||
| from pyiceberg.io.fsspec import FsspecFileIO | ||
|
|
||
| if isinstance(io, FsspecFileIO): | ||
| from pyarrow.fs import PyFileSystem | ||
|
|
||
| return PyFileSystem(FSSpecHandler(io.get_fs(scheme))) | ||
| else: | ||
| raise ValueError(f"Expected PyArrowFileIO or FsspecFileIO, got: {io}") | ||
| except ModuleNotFoundError as e: | ||
| # When FsSpec is not installed | ||
| raise ValueError(f"Expected PyArrowFileIO or FsspecFileIO, got: {io}") from e |
Collaborator
Author
There was a problem hiding this comment.
Yes, copied it over since it'll be deprecated!
| Returns an Iterator of pa.RecordBatch with data from the Iceberg table | ||
| by resolving the right columns that match the current table schema. | ||
| Only data that matches the provided row_filter expression is returned. | ||
|
|
Contributor
There was a problem hiding this comment.
nit: add a snippet about why use this instead of project_table
| ) -> None: | ||
| self._table_metadata = table_metadata | ||
| self._io = io | ||
| self._fs = _fs_from_file_path(table_metadata.location, io) # TODO: use different FileSystem per file |
kevinjqliu
reviewed
Aug 15, 2024
kevinjqliu
reviewed
Aug 15, 2024
Contributor
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM!! a few minor comments.
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
Fokko
reviewed
Aug 20, 2024
| _limit: Optional[int] | ||
| """Scan the Iceberg Table and create an Arrow construct. | ||
|
|
||
| Attributes: |
Contributor
There was a problem hiding this comment.
nit: More of a style thing. I think it is more valuable to have a docstring at the __init__ method since that's wat probably will show up people's IDE.
Fokko
approved these changes
Aug 20, 2024
Contributor
Fokko
left a comment
There was a problem hiding this comment.
This looks good, some much needed refactoring, thanks @sungwy for picking this up, and thanks @corleyma, @kevinjqliu and @ndrluis for the review!
sungwy
added a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* refactoring * refactor more * docstring * apache#1042 * adopt review feedback * thanks Kevin! Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com> --------- Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
sungwy
added a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* refactoring * refactor more * docstring * apache#1042 * adopt review feedback * thanks Kevin! Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com> --------- Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.