Skip to content

VR: Do not add iptables rules for the revoked ip addresses#6189

Merged
nvazquez merged 1 commit intoapache:4.16from
weizhouapache:4.16-vr-no-rules-for-revoked-ip-address
Apr 6, 2022
Merged

VR: Do not add iptables rules for the revoked ip addresses#6189
nvazquez merged 1 commit intoapache:4.16from
weizhouapache:4.16-vr-no-rules-for-revoked-ip-address

Conversation

@weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Mar 31, 2022

Description

This PR removes the rules for the ip addresses which are not used.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache
Copy link
Member Author

weizhouapache commented Mar 31, 2022

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Mar 31, 2022

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 31, 2022

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3043

@weizhouapache
Copy link
Member Author

weizhouapache commented Mar 31, 2022

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Mar 31, 2022

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

DaanHoogland
DaanHoogland approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@weizhouapache
Copy link
Member Author

weizhouapache commented Apr 1, 2022

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Apr 1, 2022

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@nvazquez nvazquez added this to the 4.17.0.0 milestone Apr 1, 2022
@blueorangutan
Copy link

blueorangutan commented Apr 1, 2022

Trillian test result (tid-3790)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32388 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6189-t3790-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

nvazquez
nvazquez approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvazquez nvazquez merged commit c61ea9f into apache:4.16 Apr 6, 2022
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache @yadvr
VR: Do not add iptables rules for the revoked ip addresses (apache#6189)
b832031 
(cherry picked from commit c61ea9f)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache @yadvr
VR: Do not add iptables rules for the revoked ip addresses (apache#6189)
29d2a86 
(cherry picked from commit c61ea9f)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache @yadvr
VR: Do not add iptables rules for the revoked ip addresses (apache#6189)
e762fd1 
(cherry picked from commit c61ea9f)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache @yadvr
VR: Do not add iptables rules for the revoked ip addresses (apache#6189)
e23fded 
(cherry picked from commit c61ea9f)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache @yadvr
VR: Do not add iptables rules for the revoked ip addresses (apache#6189)
896faca 
(cherry picked from commit c61ea9f)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@weizhouapache weizhouapache deleted the 4.16-vr-no-rules-for-revoked-ip-address branch December 9, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@nvazquez nvazquez nvazquez approved these changes

Assignees

No one assigned

Labels

component:virtual-router type:bug

Projects

No open projects
Apache CloudStack 4.17.0
Status: Done

Milestone

4.17.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@weizhouapache @blueorangutan @yadvr @DaanHoogland @nvazquez