set width of dropdown select items for Network Offering by DaanHoogland · Pull Request #11899 · apache/cloudstack

DaanHoogland · 2025-10-23T12:49:41Z

set width of dropdown select items for Network Offering during add tier dialog

Description

This PR is kind of experimental but, ...

Fixes: #11861

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2025-10-23T12:57:56Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.62%. Comparing base (7324ef4) to head (1b8464b).

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #11899   +/-   ##
=========================================
  Coverage     17.62%   17.62%           
- Complexity    15668    15669    +1     
=========================================
  Files          5917     5917           
  Lines        531255   531255           
  Branches      64951    64951           
=========================================
+ Hits          93639    93640    +1     
+ Misses       427077   427076    -1     
  Partials      10539    10539

Flag	Coverage Δ
uitests	`3.70% <ø> (ø)`
unittests	`18.69% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kiranchavala · 2025-10-31T04:12:52Z

@blueorangutan ui

kiranchavala · 2025-10-31T04:44:13Z

@DaanHoogland

A little bit better.

Can the entire description be displayed

"Offering for Isolated Vpc networks with Source Nat service enabled and LB service Disabled"

kiranchavala

LGTM

Can scroll the description

ui/src/views/network/VpcTiersTab.vue

shwstppr · 2025-11-28T09:14:38Z

@DaanHoogland I feel a bit more elegant way could be showing a tooltip when the item is hovered,

diff --git a/ui/src/views/network/VpcTiersTab.vue b/ui/src/views/network/VpcTiersTab.vue
index 4f6aaef444..7fe706daba 100644
--- a/ui/src/views/network/VpcTiersTab.vue
+++ b/ui/src/views/network/VpcTiersTab.vue
@@ -194,7 +194,11 @@
               :filterOption="(input, option) => {
                 return option.label.toLowerCase().indexOf(input.toLowerCase()) >= 0
               }" >
-              <a-select-option v-for="item in networkOfferings" :key="item.id" :value="item.id" :label="item.displaytext || item.name || item.description">
+              <a-select-option
+                v-for="item in networkOfferings"
+                :key="item.id"
+                :value="item.id"
+                :title="item.displaytext || item.name || item.description">
                 {{ item.displaytext || item.name || item.description }}
               </a-select-option>
             </a-select>

ui/src/views/network/VpcTiersTab.vue

DaanHoogland · 2025-12-09T09:42:39Z

@blueorangutan ui

blueorangutan · 2025-12-09T09:43:04Z

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-12-09T10:03:37Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11899 (QA-JID-826)

DaanHoogland · 2025-12-09T10:14:03Z

@kiranchavala @shwstppr, can you have another look?

shwstppr

LGTM - tested on QA server

Though I see same problem in Update form form a network tier as well. At some point may be we should move all selects to InfiniteScrollSelect... with this tooltip behaviour

DaanHoogland · 2025-12-23T20:13:08Z

@blueorangutan ui

blueorangutan · 2025-12-23T20:14:04Z

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-12-23T20:35:50Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11899 (QA-JID-834)

DaanHoogland · 2025-12-24T07:51:31Z

ping @kiranchavala

rajujith · 2026-01-12T08:36:01Z

@DaanHoogland Since this is for the 4.22.1 release, could you retarget the PR to the 4.22 branch?

sureshanaparti · 2026-02-13T05:29:33Z

@blueorangutan ui

…er dialog

DaanHoogland · 2026-02-13T08:54:14Z

@blueorangutan ui

blueorangutan · 2026-02-13T08:55:04Z

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2026-02-13T09:17:44Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11899 (QA-JID-874)

boring-cyborg bot added the component:UI label Oct 23, 2025

DaanHoogland mentioned this pull request Oct 23, 2025

UI : Complete network offering name is not displayed when creating a network tier in a vpc #11861

Open

kiranchavala reviewed Oct 31, 2025

View reviewed changes

DaanHoogland force-pushed the ghi11861-dropdownWidthForNetOffer branch from 8595ed7 to b60d8fb Compare October 31, 2025 08:32

DaanHoogland marked this pull request as ready for review October 31, 2025 08:33

DaanHoogland added the status:needs-review label Nov 4, 2025

DaanHoogland added this to the 4.22.1 milestone Nov 4, 2025

DaanHoogland commented Nov 4, 2025

View reviewed changes

ui/src/views/network/VpcTiersTab.vue Outdated Show resolved Hide resolved

DaanHoogland commented Nov 28, 2025

View reviewed changes

ui/src/views/network/VpcTiersTab.vue Outdated Show resolved Hide resolved

DaanHoogland force-pushed the ghi11861-dropdownWidthForNetOffer branch from 48b4ab4 to 5aca736 Compare December 8, 2025 15:57

apache deleted a comment from blueorangutan Dec 8, 2025

DaanHoogland requested review from kiranchavala and shwstppr December 8, 2025 15:59

apache deleted a comment from blueorangutan Dec 9, 2025

DaanHoogland commented Dec 9, 2025

View reviewed changes

ui/src/views/network/VpcTiersTab.vue Outdated Show resolved Hide resolved

apache deleted a comment from blueorangutan Dec 9, 2025

DaanHoogland commented Dec 9, 2025

View reviewed changes

ui/src/views/network/VpcTiersTab.vue Outdated Show resolved Hide resolved

shwstppr approved these changes Dec 9, 2025

View reviewed changes

DaanHoogland force-pushed the ghi11861-dropdownWidthForNetOffer branch from 9cd5d06 to 03b5224 Compare December 23, 2025 19:57

rajujith added this to Apache CloudStack 4.22.1 Jan 5, 2026

sureshanaparti moved this to In Progress in Apache CloudStack 4.22.1 Jan 7, 2026

DaanHoogland changed the base branch from main to 4.22 January 12, 2026 09:40

boring-cyborg bot added component:agent component:api component:build component:integration labels Jan 12, 2026

DaanHoogland changed the base branch from 4.22 to main January 12, 2026 09:41

DaanHoogland force-pushed the ghi11861-dropdownWidthForNetOffer branch from 03b5224 to 2ab28ff Compare January 12, 2026 09:49

DaanHoogland changed the base branch from main to 4.22 February 13, 2026 08:52

set width of dropdown select items for Network Offering during add ti…

1b8464b

…er dialog

DaanHoogland force-pushed the ghi11861-dropdownWidthForNetOffer branch from 2ab28ff to 1b8464b Compare February 13, 2026 08:53

Conversation

DaanHoogland commented Oct 23, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kiranchavala commented Oct 31, 2025

Uh oh!

kiranchavala commented Oct 31, 2025

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shwstppr commented Nov 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DaanHoogland commented Dec 9, 2025

Uh oh!

blueorangutan commented Dec 9, 2025

Uh oh!

blueorangutan commented Dec 9, 2025

Uh oh!

DaanHoogland commented Dec 9, 2025

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Dec 23, 2025

Uh oh!

blueorangutan commented Dec 23, 2025

Uh oh!

blueorangutan commented Dec 23, 2025

Uh oh!

DaanHoogland commented Dec 24, 2025

Uh oh!

rajujith commented Jan 12, 2026

Uh oh!

sureshanaparti commented Feb 13, 2026

Uh oh!

DaanHoogland commented Feb 13, 2026

Uh oh!

blueorangutan commented Feb 13, 2026

Uh oh!

blueorangutan commented Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Oct 23, 2025 •

edited

Loading