Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Fix ItemLongClickHandler #991

Merged
yDelouis merged 3 commits into from
Aug 17, 2014
Merged

Fix ItemLongClickHandler #991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7ffd14
Fix ItemLongClickHandler
yDelouis Mar 27, 2014
d28722c
Add test
yDelouis May 11, 2014
a0bca69
Merge upstream changes
yDelouis Jun 29, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ...androidannotations/src/main/java/org/androidannotations/handler/ItemLongClickHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import com.sun.codemodel.*;

import org.androidannotations.annotations.ItemLongClick;
import org.androidannotations.helper.APTCodeModelHelper;
import org.androidannotations.holder.EComponentWithViewSupportHolder;
import org.androidannotations.model.AnnotationElements;
import org.androidannotations.process.IsValid;
Expand All @@ -36,6 +37,8 @@

public class ItemLongClickHandler extends AbstractListenerHandler {

private final APTCodeModelHelper codeModelHelper = new APTCodeModelHelper();

public ItemLongClickHandler(ProcessingEnvironment processingEnvironment) {
super(ItemLongClick.class, processingEnvironment);
}
Expand Down Expand Up @@ -79,8 +82,12 @@ protected void processParameters(EComponentWithViewSupportHolder holder, JMethod
if (parameterType.getKind() == TypeKind.INT) {
call.arg(onItemClickPositionParam);
} else {
String parameterTypeQualifiedName = parameterType.toString();
call.arg(cast(refClass(parameterTypeQualifiedName), invoke(onItemClickParentParam, "getAdapter").invoke("getItem").arg(onItemClickPositionParam)));
JClass parameterClass = codeModelHelper.typeMirrorToJClass(parameterType, getHolder());
call.arg(cast(parameterClass, invoke(onItemClickParentParam, "getAdapter").invoke("getItem").arg(onItemClickPositionParam)));

if (parameterClass.isParameterized()) {
listenerMethod.annotate(SuppressWarnings.class).param("value", "unchecked");
}
}
}
}
Expand Down
22 changes: 12 additions & 10 deletions ...ional-test-1-5/src/main/java/org/androidannotations/test15/ItemClicksHandledActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,14 @@
*/
package org.androidannotations.test15;

import org.androidannotations.annotations.AfterViews;
import org.androidannotations.annotations.EActivity;
import org.androidannotations.annotations.ItemClick;
import org.androidannotations.annotations.ItemLongClick;
import org.androidannotations.annotations.ItemSelect;
import org.androidannotations.annotations.ViewById;

import java.util.ArrayList;
import java.util.List;

import android.app.Activity;
import android.widget.ArrayAdapter;
import android.widget.ListView;
import android.widget.Spinner;
import org.androidannotations.annotations.*;

import java.util.ArrayList;
import java.util.List;

@EActivity(R.layout.item_clicks_handled)
public class ItemClicksHandledActivity extends Activity {
Expand Down Expand Up @@ -150,6 +144,14 @@ void listViewWithPositionItemLongClicked(int position) {

}

@ItemLongClick(R.id.listViewWithArgumentWithParameterType)
protected void listViewWithArgumentWithParameterTypeLongClick(ArrayList<String> item) {
}

@ItemLongClick(R.id.listViewWithArgumentWithGenericWildcard)
protected void listViewWithArgumentWithGenericWildcardTypeLongClick(ArrayList<?> item) {
}

private List<ArrayList<String>> stringLists() {
List<ArrayList<String>> stringLists = new ArrayList<ArrayList<String>>();
for (int i = 0; i < 10; i++) {
Expand Down