This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Support Android Gradle Plugin 3.5.0-beta03 and 3.6.0-alpha01#2231
Merged
WonderCsabo merged 4 commits intoandroidannotations:developfrom Aug 30, 2019
dodgex:2229_update_manifest_finder
Merged
Support Android Gradle Plugin 3.5.0-beta03 and 3.6.0-alpha01#2231WonderCsabo merged 4 commits intoandroidannotations:developfrom dodgex:2229_update_manifest_finder
WonderCsabo merged 4 commits intoandroidannotations:developfrom
dodgex:2229_update_manifest_finder
Conversation
(cherry picked from commit 1c48970ade71852c8a3e305641ef88a105d35f2d)
(cherry picked from commit c7bc0b574234c537b4f976df35d215eba8b7f9a0)
(cherry picked from commit de366e34d77424c95be0ddce1e1e1fdd4c70bbd7)
(cherry picked from commit 754a09a69f9740695dadb7900113ba1e98a9f7dc)
lucalves
reviewed
Jun 14, 2019
...dannotations/src/main/java/org/androidannotations/internal/helper/AndroidManifestFinder.java
Show resolved
Hide resolved
|
Hello there, could anyone review this?? AA is failing for the new android gradle plugin released (3.5.0). |
Member
|
I'll try to review this on Monday. |
WonderCsabo
approved these changes
Aug 30, 2019
Member
|
The fix is now available in the 4.7.0-SNAPSHOT build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google updated the generated code folder for Java Builds and with this PR we support those new folders for Manifest detection. :)
Fixes #2229.