This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Fix for @ViewById generic issues#1353
Merged
yDelouis merged 3 commits intoandroidannotations:developfrom Apr 6, 2015
Merged
Conversation
0dc46ac to
88f3511
Compare
Member
Author
There was a problem hiding this comment.
I changed this because now we do not need the TypeElement passed to this method, which is not always available. I know this is ugly and an anti-pattern, but the other way is using 30 lines of reflective code to access the needed values from CodeModel. 😟
88f3511 to
df6e8f0
Compare
Member
Author
|
PR updated |
yDelouis
added a commit
that referenced
this pull request
Apr 6, 2015
Fix for @ViewById generic issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1351.