Remove uuid dependency#561
Merged
andrcuns merged 1 commit intoallure-framework:masterfrom Aug 20, 2024
kpumuk:uuid
Merged
Conversation
|
|
|
Code Climate has analyzed commit 14e5af4 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 98.9% (0.0% change). View more on Code Climate. |
Contributor
Author
|
I probably can't do much about the CI failure
|
Collaborator
|
Makes perfect sense, less dependencies is always good 👍 CI failure is not critical, it couldn't upload the report, not a big deal. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
uuidgem is archived on GitHub since Jan 1, 2024: https://github.com/assaf/uuidAlthough one might consider it feature complete and no longer require any updates (in fact, the last update was made 5 years ago), I would still consider it a risk. Its transitive dependencies
macaddrandsystemuwere updated in 2019 and 2015 respectively.The change removes 3 dependencies:
uuid»macaddr»systemu.How
Ruby already has a way to generate UUIDs via
SecureRandom. It is v4 (compared to v1 implemented by theuuidgem), but for Allure purposes it should make no difference. Another option is PRNG version implemented inRandom#uuid_v4andRandom#uuid_v7, but it requires an instance of PRNG, and so more code changes.