Feature: Allow multi-span colorbars#394
Merged
beckermr merged 8 commits intoUltraplot:mainfrom Oct 31, 2025
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
beckermr
requested changes
Oct 31, 2025
Collaborator
beckermr
left a comment
There was a problem hiding this comment.
I don't get why span/rows/cols start with the first column at 1 instead of at 0. Has it always been this way?
It makes this code confusing:
fig.colorbar(cm, ax=axs[0, 0], span=(1, 2), loc="bottom")
The axes indices are offset by 1 from the span values.
beckermr
approved these changes
Oct 31, 2025
Collaborator
beckermr
left a comment
There was a problem hiding this comment.
NVM it has been that way always. Very confusing but it is what it is.
Collaborator
Author
I read it as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #393
Closes #392
Enables
fig.colorbar()to use bothax(positioning) andspan/rows/cols(extent) parameters together. Previously, span was ignored whenaxwas provided.Examples
Notes
span=orcols=for horizontal colorbars (top/bottom)rows=for vertical colorbars (left/right)fig.colorbar(cm, ax=axs[:])still workstest_colorbar.py