Feature: allow cycle objects to be set on rc#378
Merged
cvanelteren merged 5 commits intoUltraplot:mainfrom Oct 25, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables users to set cycle objects directly on the rc configuration, improving user experience for defining default cycle colors. Users can now pass color lists or Cycle objects in addition to string names.
Key Changes:
- Extended
_validate_cmapfunction to handleCycleobjects and color lists when validating cycle configurations - Added test coverage for different cycle input formats (string names, color lists,
Cycleobjects, and invalid inputs)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ultraplot/internals/rcsetup.py | Modified _validate_cmap to accept and validate Cycle objects and iterables when cycle=True parameter is set |
| ultraplot/tests/test_config.py | Added parameterized test to verify cycle setting behavior with various input types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #200
With the improved
Configuratorinstantiation, we can now more easily allow for cycle passing to enhance user experience to define default cycle colors. This PR introduces the ability for users to pass on lists of colors orCycleobjects directly.