Closed
Conversation
Collaborator
Author
|
I am open for bundling the package directly. The source is just a simple formatters that are registered. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
beckermr
requested changes
Jun 26, 2025
Collaborator
beckermr
left a comment
There was a problem hiding this comment.
The package seems well maintained, so let's depend on it. This PR needs a test.
Collaborator
Author
Collaborator
Author
|
Closing in favor of #344 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plotting on non-gregorian time scales raises an error. Matplotlib by default does not allow for this. Luckily there is a fix. By installing
nc-time-axissome formatters are registered that allows for this. We can either implement this natively or add an install requirementCurrently I just implemented an error when one is plotting in a non-gregorian calendar (issue raised in #288).