Remove unreachable Case 1 in radix tree insert and handle exact match…#14269
Open
tri-23-dip wants to merge 1 commit intoTheAlgorithms:masterfrom
Open
Remove unreachable Case 1 in radix tree insert and handle exact match…#14269tri-23-dip wants to merge 1 commit intoTheAlgorithms:masterfrom
tri-23-dip wants to merge 1 commit intoTheAlgorithms:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… inside Case 3
Describe your change: Fixes #11316
The insert() method in radix_tree.py contained a Case 1 branch that was
practically unreachable due to how recursion is structured.
Exact matches are detected during prefix matching (Case 3),
so handling the exact-match case there removes redundancy
and simplifies the logic.
This change removes the unreachable Case 1 branch
and handles exact matches directly inside Case 3
without altering existing behavior.
Checklist: