fix: resolve startup RecursionError on Windows (Issue #13) and improve project onboarding#14
Open
0xC1ph3rX wants to merge 1 commit intoScriptSmith:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the startup crash reported in Issue #13 and improves setup reliability for contributors running Reaper from source.
Main fix (Issue #13)
components/globals.pyhad recursive path traversal in_calc_path()that could loop forever on Windows drive/root boundaries, causing:RecursionError: maximum recursion depth exceededI replaced the recursive implementation with an iterative parent walk and added safe base cases so traversal stops correctly at root boundaries.
Additional improvements included in this branch
tests/test_globals.py).README.md(Windows/macOS/Linux, dependency and API-key setup guidance)..github/workflows/ci.yml) for Python 3.10, 3.11, 3.12.pyproject.toml) and dev requirements (requirements-dev.txt).requirements.txt.components/job_queue.pyfor invalid credentials and deprecated/changed endpoints.Validation
Ran locally:
python3 -m unittest discover -s tests -p "test_*.py"python3 -m py_compile components/globals.py components/job_queue.py reaper.pypython3 -c "import os; from components.globals import BUNDLE_DIR; assert os.path.isdir(BUNDLE_DIR)"Closes #13.