Skip to content

Fix artifact Download issue in release build#9095

Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom
TravisEz13:fix_artifact_Download
Mar 8, 2019
Merged

Fix artifact Download issue in release build#9095
TravisEz13 merged 1 commit intoPowerShell:masterfrom
TravisEz13:fix_artifact_Download

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Mar 8, 2019

PR Summary

Fix artifact Download issue in release build

PR Context

PR Checklist

Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign off to unblock the build. But I don't really understand the change 😃 Left a question below for my education.

finalResults/powershell-*.tar.gz
results/powershell-*-osx-x64.tar.gz
downloadType: single
artifactName: finalResults
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is finalResults a folder or a single file? Is this change actually copies all items in the finalResults folder to $(System.ArtifactsDirectory)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change, yes downloads all files from finalResults. I always hit some issue if I tried the filters, and this was faster than what we had before so I stopped here.

Copy link
Member Author

@TravisEz13 TravisEz13 Mar 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You questions indicates you understood the change well enough.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw finalResults appears in the build log as a folder :) A lucky guess

@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 8, 2019
@TravisEz13 TravisEz13 merged commit 382e5cc into PowerShell:master Mar 8, 2019
@TravisEz13 TravisEz13 deleted the fix_artifact_Download branch March 8, 2019 23:18
TravisEz13 added a commit that referenced this pull request Mar 13, 2019
Fix artifact Download issue in release build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants