Fixed Dockerfile syntax highlighting#8991
Merged
TravisEz13 merged 5 commits intoPowerShell:masterfrom Mar 11, 2019
RDIL:patch-3
Merged
Fixed Dockerfile syntax highlighting#8991TravisEz13 merged 5 commits intoPowerShell:masterfrom RDIL:patch-3
TravisEz13 merged 5 commits intoPowerShell:masterfrom
RDIL:patch-3
Conversation
iSazonov
approved these changes
Feb 26, 2019
Member
|
This affects our release build. I'll need to clone the branch into our release build system and verify this does not cause an issue. It will take some time to validate. Please be patient |
Contributor
Author
|
Not a problem. |
TravisEz13
pushed a commit
that referenced
this pull request
Mar 13, 2019
The `f` in Dockerfile is not uppercase, this breaks syntax highlighting for vscode on my client <!-- Summarize your PR between here and the checklist. --> ## PR Context `DockerFile` breaks syntax highlighting as mentioned and described above. <!-- Provide a little reasoning as to why this Pull Request helps and why you have opened it. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The
fin Dockerfile is not uppercase, this breaks syntax highlighting for vscode on my clientPR Context
DockerFilebreaks syntax highlighting as mentioned and described above.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests