tab completion test doesn't handle multiple matches#8891
Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom Mar 11, 2019
Merged
tab completion test doesn't handle multiple matches#8891daxian-dbw merged 1 commit intoPowerShell:masterfrom
daxian-dbw merged 1 commit intoPowerShell:masterfrom
Conversation
…defined, harden the test to handle multiple matches
adityapatwardhan
approved these changes
Feb 13, 2019
iSazonov
reviewed
Feb 14, 2019
| $res = TabExpansion2 -inputScript $inputStr -cursorColumn $inputStr.Length | ||
| $res.CompletionMatches.Count | Should -BeGreaterThan 0 | ||
| $res.CompletionMatches[0].CompletionText | Should -BeExactly $expected | ||
| $res.CompletionMatches.CompletionText | Should -Contain $expected |
Collaborator
There was a problem hiding this comment.
Is order/position important in the test?
Collaborator
|
Is the PR ready to merge? |
Collaborator
|
@daxian-dbw Please clarify about setting a milestone to merged PR. Is there new guidelines? |
Member
|
After RC release, we created the v6.2.0 branch, which will be the branch to use for 6.2.0 GA release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Some environments have multiple matches, so some TabCompletion tests may fail because of an assumption that there is only 1 possible match. I'm seeing this specifically on the Linux container validation runs, but it seems like it would be general problem.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests