Change xUnit RunspaceTests to run sequentially#8796
Merged
adityapatwardhan merged 3 commits intoPowerShell:masterfrom Jan 30, 2019
PaulHigin:skip-parallel-runspacetest
Merged
Change xUnit RunspaceTests to run sequentially#8796adityapatwardhan merged 3 commits intoPowerShell:masterfrom PaulHigin:skip-parallel-runspacetest
adityapatwardhan merged 3 commits intoPowerShell:masterfrom
PaulHigin:skip-parallel-runspacetest
Conversation
adityapatwardhan
approved these changes
Jan 30, 2019
Collaborator
|
If we turn off this test we will never fix the race condition which is very bad for real world scenarios. I suggest to review and merge #8779 that will eliminate inter-thread race conditions. Then we could think more about inter-process race conditions. I already look this and couldl push a PR. |
Member
|
@PaulHigin Could you look at the xUnit failure? |
Contributor
Author
|
@adityapatwardhan @iSazonov The tests are still failing (but in a different test), and in the same way (malformed file path). So I will re-enable the test and try running as sequential instead of parallel, to verify this is indeed a race condition. |
Member
|
Not waiting the recommended 24 hours since this is blocking PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
XUnit parallel runspace tests are failing with obscure errors. This appears to be due to parallelism and the tests appear to pass when run serially. This change is to convert the RunspaceTests to Sequential operation
PR Context
These tests have been failing fairly consistently if randomly in our daily builds, and appear to be due to running them in parallel.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests