Skip to content

Improve check for developer mode by checking minimum required build number#8749

Merged
TravisEz13 merged 5 commits intoPowerShell:masterfrom
adityapatwardhan:FixSymLinkTest
Jan 25, 2019
Merged

Improve check for developer mode by checking minimum required build number#8749
TravisEz13 merged 5 commits intoPowerShell:masterfrom
adityapatwardhan:FixSymLinkTest

Conversation

@adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Jan 25, 2019 •
edited
Loading

PR Summary

The test would fail if the developer mode is enabled but the machine has an older build than the minimum required build.
The change adds a check for the build version in the test.

PR Context

The current is causing CI failures.

PR Checklist

@adityapatwardhan
Improve check for developer mode by checking minimum required build n…
961d585 
…umber

The test would fail if the developer mode is enabled but the machine has an older build than the minimum required build.
The change adds a check for the build version in the test.
@adityapatwardhan adityapatwardhan self-assigned this Jan 25, 2019
JamesWTruher
JamesWTruher approved these changes Jan 25, 2019
View reviewed changes
Copy link
Collaborator

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't blocking, but it might be easier to read/maintain

@TravisEz13
Copy link
Member

TravisEz13 commented Jan 25, 2019

merging this because it is blocking PRs.

@TravisEz13 TravisEz13 merged commit 6ccbebd into PowerShell:master Jan 25, 2019
@adityapatwardhan adityapatwardhan deleted the FixSymLinkTest branch January 25, 2019 23:46
@iSazonov iSazonov added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Feb 1, 2019
@powercode
Copy link
Collaborator

powercode commented Feb 6, 2019

@adityapatwardhan I'm a bit late to the party here, but I noticed that we are depending a manifest in the binary for OSVersion to give correct results. This doesn't seem to happen when we run the tests, as they are loaded into the dotnet.exe binary. I get version 6.2 on my windows 10 machine when running the tests.

@SteveL-MSFT
Copy link
Member

SteveL-MSFT commented Feb 6, 2019

@powercode Windows API, by default, will return 6.2 for the Windows Version. For Windows PowerShell and PowerShell Core, we rely on a compatibility section in the app manifest to have it return 10. If you're referring to unit tests running in dotnet.exe, it may be ok to expect 6.2 as long as it's understood.

@powercode
Copy link
Collaborator

powercode commented Feb 7, 2019

@SteveL-MSFT It's just annoying when the tests don't behave as the product.
Maybe the right thing to do to get dotnet.exe to have a manifest too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@BrucePay BrucePay Awaiting requested review from BrucePay

+1 more reviewer

@JamesWTruher JamesWTruher JamesWTruher approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adityapatwardhan adityapatwardhan

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@adityapatwardhan @TravisEz13 @powercode @SteveL-MSFT @JamesWTruher @iSazonov