Remove AMSI unitialized assert and replace with call to uninitialize#8713
Merged
adityapatwardhan merged 2 commits intoPowerShell:masterfrom Jan 23, 2019
PaulHigin:remove-overactive-amsi-assert
Merged
Remove AMSI unitialized assert and replace with call to uninitialize#8713adityapatwardhan merged 2 commits intoPowerShell:masterfrom PaulHigin:remove-overactive-amsi-assert
adityapatwardhan merged 2 commits intoPowerShell:masterfrom
PaulHigin:remove-overactive-amsi-assert
Conversation
adityapatwardhan
approved these changes
Jan 22, 2019
bergmeister
approved these changes
Jan 23, 2019
Collaborator
|
@PaulHigin Many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
AMSI is not getting uninitialized when a PowerShell shell window is closed by clicking the 'close' button instead of typing 'exit' at the command line, because the final runspace is not being closed. There is an assert checking for AMSI uninitialized during a CLR process exit, and it fires every time the window is closed via the close button. This fix removes the assert and replaces it with a check and call to uninitialize AMSI.
PR Context
The assert is very annoying and does nothing useful.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests