Remove extra AppVeyor environment check#8709
Merged
TravisEz13 merged 2 commits intoPowerShell:masterfrom Feb 8, 2019
RDIL:patch-1
Merged
Remove extra AppVeyor environment check#8709TravisEz13 merged 2 commits intoPowerShell:masterfrom RDIL:patch-1
TravisEz13 merged 2 commits intoPowerShell:masterfrom
RDIL:patch-1
Conversation
bergmeister
suggested changes
Jan 23, 2019
bergmeister
approved these changes
Jan 23, 2019
iSazonov
approved these changes
Jan 23, 2019
Collaborator
|
Do we still use appveyor.psm1 ? |
Contributor
Author
|
@iSazonov Yeah, the Windows VSTS agent imports it. It could be renamed. |
Contributor
Author
Collaborator
|
Thanks. I see. Maybe need rename... |
Contributor
Author
|
I can do that if you would like. |
Collaborator
|
Not in the PR and if @TravisEz13 agrees. |
Contributor
Author
|
Alright, if Mr. Plunk gives his 👍 then I'll open a different PR for it. |
TravisEz13
reviewed
Jan 24, 2019
Collaborator
|
@TravisEz13 Could you please merge? |
TravisEz13
approved these changes
Feb 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Removes a check for AppVeyor env
PR Context
AppVeyor removed (#8686 extension)
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests