Fix Code Page Parsing Isssue in Invoke-RestMethod#8694
Merged
adityapatwardhan merged 2 commits intoPowerShell:masterfrom Jan 22, 2019
Merged
Fix Code Page Parsing Isssue in Invoke-RestMethod#8694adityapatwardhan merged 2 commits intoPowerShell:masterfrom
adityapatwardhan merged 2 commits intoPowerShell:masterfrom
Conversation
Collaborator
|
Can we add test to exclude a regression? |
5ed5e7e to
ec75e7d
Compare
Contributor
Author
|
@iSazonov tests added. |
iSazonov
approved these changes
Jan 19, 2019
daxian-dbw
approved these changes
Jan 21, 2019
Collaborator
|
@adityapatwardhan Could you please merge the PR? |
adityapatwardhan
approved these changes
Jan 22, 2019
Member
|
@markekraus Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #8510
Our verbose message for testing Encoding results in a
NotSupportedExceptionon some encoding types. This PR introduces a workaround for when the exception is throw accessingencoding.headerNamePR Context
#8510
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests