Add function to create a framework dependent package dotnet-sdk containers#8644
Merged
adityapatwardhan merged 4 commits intoPowerShell:masterfrom Jan 16, 2019
Merged
Conversation
PaulHigin
approved these changes
Jan 14, 2019
TravisEz13
reviewed
Jan 15, 2019
TravisEz13
reviewed
Jan 15, 2019
TravisEz13
reviewed
Jan 15, 2019
TravisEz13
requested changes
Jan 15, 2019
Member
TravisEz13
left a comment
There was a problem hiding this comment.
I would like you to fix the Write-Log comment before merging.
Member
Author
|
@TravisEz13 can you re-review, your comments have been addressed. |
Member
Author
|
@anmenaga - Please have a look I have made changes to package verification tests. |
Member
Author
|
Codacy error is due to |
anmenaga
approved these changes
Jan 15, 2019
TravisEz13
approved these changes
Jan 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Create a framework dependent package with reduced size specially for docker containers based on dotnet-sdk containers.
PR Context
The size of the framework dependent package is pretty large. It has assemblies of runtimes which are not required for the dotnet-sdk container images. This PR creates a new package with a reduced size.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests