Make Join-String -InputObject 1,2,3 result equal to 1,2,3 | Join-String result#8611
Merged
TravisEz13 merged 5 commits intoPowerShell:masterfrom Jan 24, 2019
Merged
Make Join-String -InputObject 1,2,3 result equal to 1,2,3 | Join-String result#8611TravisEz13 merged 5 commits intoPowerShell:masterfrom
Join-String -InputObject 1,2,3 result equal to 1,2,3 | Join-String result#8611TravisEz13 merged 5 commits intoPowerShell:masterfrom
Conversation
iSazonov
reviewed
Jan 9, 2019
src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-string.cs
Outdated
Show resolved
Hide resolved
iSazonov
reviewed
Jan 9, 2019
src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-string.cs
Show resolved
Hide resolved
…n-string.cs Co-Authored-By: sethvs <sethvs@users.noreply.github.com>
PaulHigin
previously approved these changes
Jan 10, 2019
Sorry, I approved the wrong PR. I'll look at this soon.
Member
|
Requesting committee review for the new behavior |
TravisEz13
approved these changes
Jan 17, 2019
Join-String -InputObject 1,2,3 result equal to 1,2,3 | Join-String resultJoin-String -InputObject 1,2,3 result equal to 1,2,3 | Join-String result
Collaborator
|
Add WIP until PowerShell Committee review. |
Member
|
@PowerShell/powershell-committee reviewed this. In this particular case because it's dealing with strings, it is acceptable to have this desired behavior. Since |
Join-String -InputObject 1,2,3 result equal to 1,2,3 | Join-String resultJoin-String -InputObject 1,2,3 result equal to 1,2,3 | Join-String result
Contributor
Author
|
PowerShell Committee reviewed this, so remove WIP. |
iSazonov
approved these changes
Jan 24, 2019
Collaborator
|
@sethvs Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Make
Join-String -InputObject 1,2,3result equal to1,2,3 | Join-Stringresult.Fix #8610
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests