Skip to content

Style: Change Char to char and Boolean to bool#8572

Merged
daxian-dbw merged 10 commits intoPowerShell:masterfrom
iSazonov:style-char-alias
Jan 7, 2019
Merged

Style: Change Char to char and Boolean to bool#8572
daxian-dbw merged 10 commits intoPowerShell:masterfrom
iSazonov:style-char-alias

Conversation

@iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Dec 31, 2018 •
edited
Loading

PR Summary

Change Char to char and Boolean to bool.

PR Checklist

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 31, 2018
@iSazonov iSazonov force-pushed the style-char-alias branch 5 times, most recently from 7291bf1 to c6384ed Compare December 31, 2018 20:50
@iSazonov iSazonov changed the title Style: Change Char to char and Boolean to boolean Style: Change Char to char and Boolean to bool Dec 31, 2018
daxian-dbw
daxian-dbw requested changes Jan 6, 2019
View reviewed changes
@daxian-dbw daxian-dbw self-assigned this Jan 6, 2019
@iSazonov
Copy link
Collaborator Author

iSazonov commented Jan 6, 2019

@daxian-dbw Your comments is addressed and the merge conflict is resolved.

daxian-dbw
daxian-dbw approved these changes Jan 7, 2019
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw
Copy link
Member

daxian-dbw commented Jan 7, 2019

There is another conflict after merging your 'String-to-string' PR. Can you please resolve this one too?

@iSazonov
Copy link
Collaborator Author

iSazonov commented Jan 7, 2019

Done.

daxian-dbw
daxian-dbw approved these changes Jan 7, 2019
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@daxian-dbw daxian-dbw merged commit f95dae5 into PowerShell:master Jan 7, 2019
@iSazonov iSazonov deleted the style-char-alias branch January 7, 2019 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@BrucePay BrucePay Awaiting requested review from BrucePay

@JamesWTruher JamesWTruher Awaiting requested review from JamesWTruher

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@daxian-dbw daxian-dbw

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iSazonov @daxian-dbw