Skip to content

Style: Replace String.IsNullOrEmpty with string.IsNullOrEmpty#8557

Merged
iSazonov merged 5 commits intoPowerShell:masterfrom
iSazonov:style-string-isnullorempty
Dec 31, 2018
Merged

Style: Replace String.IsNullOrEmpty with string.IsNullOrEmpty#8557
iSazonov merged 5 commits intoPowerShell:masterfrom
iSazonov:style-string-isnullorempty

Conversation

@iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Dec 28, 2018 •
edited
Loading

PR Summary

Overlaps #8520 (where it is impossible to resolve many merge conflicts).

Fix case: replace String.IsNullOrEmpty with string.IsNullOrEmpty

PR Checklist

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 28, 2018
@xtqqczze
Copy link
Contributor

xtqqczze commented Dec 28, 2018 •
edited
Loading

Job1 ElevatedPesterTests_xUnit_Packaging failed on PowerShell-CI-windows for #PR-8557-20181228.01:

##[Error 1]
The job running on agent Hosted Agent has exceeded the maximum execution time of 120.

Looking at the logs the root cause appears to be an network connectivity issue:

2018-12-28T13:10:20.2926238Z Failed to download package 'Microsoft.AspNetCore.Authentication.Cookies.2.1.2' from 'https://api.nuget.org/v3-flatcontainer/microsoft.aspnetcore.authentication.cookies/2.1.2/microsoft.aspnetcore.authentication.cookies.2.1.2.nupkg'.
2018-12-28T13:10:20.2926402Z The SSL connection could not be established, see inner exception.
2018-12-28T13:10:20.2926463Z Authentication failed because the remote party has closed the transport stream.

@iSazonov iSazonov force-pushed the style-string-isnullorempty branch from 3fd8f63 to a265ec1 Compare December 29, 2018 13:21
@iSazonov
Copy link
Collaborator Author

iSazonov commented Dec 29, 2018

@SteveL-MSFT Tests is passed.

@iSazonov iSazonov closed this Dec 31, 2018
@iSazonov iSazonov reopened this Dec 31, 2018
@iSazonov
Copy link
Collaborator Author

iSazonov commented Dec 31, 2018

Reopen to restart CIs.

@iSazonov iSazonov closed this Dec 31, 2018
@iSazonov iSazonov reopened this Dec 31, 2018
@iSazonov iSazonov merged commit 56569b9 into PowerShell:master Dec 31, 2018
@iSazonov iSazonov deleted the style-string-isnullorempty branch December 31, 2018 10:10
@iSazonov iSazonov self-assigned this Jan 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner

@anmenaga anmenaga Awaiting requested review from anmenaga

@BrucePay BrucePay Awaiting requested review from BrucePay

@Francisco-Gamino Francisco-Gamino Awaiting requested review from Francisco-Gamino

@JamesWTruher JamesWTruher Awaiting requested review from JamesWTruher

@mirichmo mirichmo Awaiting requested review from mirichmo

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iSazonov @xtqqczze @SteveL-MSFT