Fix formatting of header of table when center aligned#8497
Merged
iSazonov merged 2 commits intoPowerShell:masterfrom Dec 22, 2018
Merged
Fix formatting of header of table when center aligned#8497iSazonov merged 2 commits intoPowerShell:masterfrom
iSazonov merged 2 commits intoPowerShell:masterfrom
Conversation
iSazonov
reviewed
Dec 20, 2018
src/System.Management.Automation/FormatAndOutput/common/TableWriter.cs
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Format-Table.Tests.ps1
Outdated
Show resolved
Hide resolved
iSazonov
approved these changes
Dec 20, 2018
69efcf7 to
f7eecba
Compare
anmenaga
approved these changes
Dec 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
In a previous change, it only applied padding if alignment was "right", but it should have applied padding whenever alignment was not "left" so that "center" alignment was also padded. Some existing tests needed to be updated where the third column was using
centeralignment and the test was expecting the header to beleftaligned (due to this bug) when the header also needed to becenteraligned.Fix #8428
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests