Skip to content

Create markdown link check task#8471

Merged
TravisEz13 merged 10 commits intoPowerShell:masterfrom
RDIL:patch-4
Jan 3, 2019
Merged

Create markdown link check task#8471
TravisEz13 merged 10 commits intoPowerShell:masterfrom
RDIL:patch-4

Conversation

@RDIL
Copy link
Contributor

@RDIL RDIL commented Dec 15, 2018

This is a WIP that checks to see if all links work or not. It may be a breaking change

@RDIL RDIL closed this Jan 2, 2019
@RDIL
Copy link
Contributor Author

RDIL commented Jan 2, 2019 via email

@RDIL RDIL reopened this Jan 3, 2019
@RDIL RDIL changed the title [feature] [ WIP ] create link check task [feature] Create link check task Jan 3, 2019
@RDIL
Copy link
Contributor Author

RDIL commented Jan 3, 2019

@TravisEz13 added to spelling CI task.

@RDIL
Copy link
Contributor Author

RDIL commented Jan 3, 2019

The check is working!!!!!! :D

@RDIL
Copy link
Contributor Author

RDIL commented Jan 3, 2019

Sadly the check doesn't return a code of 1 if dead links are found but it still works!

@TravisEz13
Copy link
Member

Can you fix the CodeFactor issues in the YAML?

Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two issues I left comments for. Add a comment about pinning versions and fix code factor issues.

@RDIL
Copy link
Contributor Author

RDIL commented Jan 3, 2019

Okay.

@RDIL
Copy link
Contributor Author

RDIL commented Jan 3, 2019

It is now fixed!!

@TravisEz13 TravisEz13 added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jan 3, 2019
@TravisEz13 TravisEz13 merged commit bb2440c into PowerShell:master Jan 3, 2019
@TravisEz13
Copy link
Member

Thank @RDIL

@RDIL RDIL deleted the patch-4 branch January 3, 2019 22:51
@RDIL
Copy link
Contributor Author

RDIL commented Jan 3, 2019

Thank you!

@iSazonov iSazonov changed the title [feature] Create link check task Create link check task Jan 4, 2019
@iSazonov iSazonov changed the title Create link check task Create markdown link check task Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants