Skip to content

Fix Join-String cmdlet FormatString parameter logic#8449

Merged
iSazonov merged 2 commits intoPowerShell:masterfrom
sethvs:joinString
Jan 9, 2019
Merged

Fix Join-String cmdlet FormatString parameter logic#8449
iSazonov merged 2 commits intoPowerShell:masterfrom
sethvs:joinString

Conversation

@sethvs
Copy link
Contributor

@sethvs sethvs commented Dec 11, 2018

PR Summary

Fix #8448
PR changes logic when applying FormatString parameter value.

PR Checklist

@iSazonov
Copy link
Collaborator

@sethvs Please add tests.

@TravisEz13 TravisEz13 added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 11, 2018
@sethvs
Copy link
Contributor Author

sethvs commented Dec 12, 2018

@iSazonov Done.

@PaulHigin
Copy link
Contributor

Looking...

Copy link
Contributor

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethvs
Copy link
Contributor Author

sethvs commented Jan 9, 2019

Close and reopen to re-trigger hung license/cla check.

@sethvs sethvs closed this Jan 9, 2019
@sethvs sethvs reopened this Jan 9, 2019
@iSazonov iSazonov self-assigned this Jan 9, 2019
@iSazonov iSazonov merged commit 6f071f0 into PowerShell:master Jan 9, 2019
@sethvs sethvs deleted the joinString branch January 9, 2019 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Join-String -FormatString parameter doesn't apply properly

4 participants