Skip to content

support for linuxmint in installpsh-debian.sh#8440

Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom
DarwinJS:issue-8437-installpsh-debian-support-for-linuxmint
Dec 11, 2018
Merged

support for linuxmint in installpsh-debian.sh#8440
TravisEz13 merged 1 commit intoPowerShell:masterfrom
DarwinJS:issue-8437-installpsh-debian-support-for-linuxmint

Conversation

@DarwinJS
Copy link
Contributor

PR Summary

Add #8437 - add linuxmint support

PR Checklist

@DarwinJS
Copy link
Contributor Author

There is an official docker image (https://hub.docker.com/r/linuxmintd/mint19-amd64/), but do you bother with doing tests only for install scripts?

@TravisEz13
Copy link
Member

I ran the install-ps CI here and set it to automatically run in the future: https://powershell.visualstudio.com/PowerShell/_build/results?buildId=7894

@TravisEz13 TravisEz13 merged commit 5478cf6 into PowerShell:master Dec 11, 2018
@TravisEz13 TravisEz13 added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Dec 11, 2018
@DarwinJS
Copy link
Contributor Author

Wow that was fast - thanks!

@TravisEz13
Copy link
Member

@DarwinJS It's a lot easier to be confident that it works with a CI system in place.

Thanks for keeping these up to date.

@DarwinJS DarwinJS deleted the issue-8437-installpsh-debian-support-for-linuxmint branch December 12, 2018 03:02
@DarwinJS
Copy link
Contributor Author

LinuxMint is worth it - finally a distro that does not annoy the daylights out of all my windows keyboard shortcut reflexes :)

@TravisEz13
Copy link
Member

I like LinuxMint too, but I found macOS has the apps I need to run it full time.

@DarwinJS
Copy link
Contributor Author

Yes - I don't use it as a primary - but for testing bash and powershell core since the rest of my team runs macs. Although I am doing more of that with Docker as well.

@TravisEz13
Copy link
Member

I started using https://github.com/CanonicalLtd/multipass for a lot of my testing of Linux from macOS. This is partly because I'm testing snap packages which don't really work in docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants