Skip to content

Fix EnvironmentVariable test and add missing null check in CommandHelpProvider#8408

Merged
TravisEz13 merged 2 commits intoPowerShell:masterfrom
adityapatwardhan:testfixes
Dec 11, 2018
Merged

Fix EnvironmentVariable test and add missing null check in CommandHelpProvider#8408
TravisEz13 merged 2 commits intoPowerShell:masterfrom
adityapatwardhan:testfixes

Conversation

@adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Dec 6, 2018

PR Summary

  • Disable NewItemUnauthorizedAccessError tests.
  • Added expected value for $env:HOMEPATH for user with temporary profile.
  • Added a missing null check in CommandHelpProvider.cs

PR Checklist

@adityapatwardhan adityapatwardhan changed the title Test fixes and missing null check Fix EnvironmentVariable test and add missing null check in CommandHelpProvider Dec 6, 2018
Copy link
Collaborator

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TravisEz13 TravisEz13 merged commit 551ed10 into PowerShell:master Dec 11, 2018
@TravisEz13 TravisEz13 added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Dec 11, 2018
@adityapatwardhan adityapatwardhan deleted the testfixes branch February 11, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants