Update the name of the artifact to be unique per artifact#8405
Merged
adityapatwardhan merged 3 commits intoPowerShell:masterfrom Dec 6, 2018
Merged
Update the name of the artifact to be unique per artifact#8405adityapatwardhan merged 3 commits intoPowerShell:masterfrom
adityapatwardhan merged 3 commits intoPowerShell:masterfrom
Conversation
adityapatwardhan
approved these changes
Dec 6, 2018
PaulHigin
reviewed
Dec 6, 2018
| [Parameter(Mandatory)] | ||
| [ValidateScript({Test-Path -Path $_})] | ||
| $Path | ||
| $Path, |
Contributor
There was a problem hiding this comment.
I think this would be more clear if $Path was named $ArtifactPath and $Name to $ArtifactName.
| } | ||
| elseif ($env:TF_BUILD -and $env:BUILD_REASON -ne 'PullRequest') { | ||
|
|
||
| if ($env:TF_BUILD) { |
Contributor
There was a problem hiding this comment.
If $env:TF_BUILD is not defined then this cmdlet does nothing. Is that Ok, or should a warning be generated?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Update the name of the artifact to be unique per artifact
Motivation: allow downloading individual artifacts
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests