Skip to content

Start-Transcript Add option to minimise transcript header#8402

Merged
daxian-dbw merged 6 commits intomasterfrom
unknown repository
Dec 20, 2018
Merged

Start-Transcript Add option to minimise transcript header#8402
daxian-dbw merged 6 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Dec 5, 2018 •
edited by iSazonov
Loading

PR Summary

Add a switch parameter UseMinimalHeader to Start-Transcript. When used, a transcript will contain a short header like the following, instead of the usual header containing version information.

**********************
PowerShell transcript start
Start time: 20181201203347
**********************

This partly addresses #8359.

PR Checklist

@ghost ghost requested review from BrucePay, anmenaga and daxian-dbw as code owners December 5, 2018 11:46
@iSazonov
Copy link
Collaborator

iSazonov commented Dec 7, 2018

@lukexjeremy Thanks for your contribution!
You could look Start-Transcript.Tests.ps1 for tests.

@ghost ghost changed the title WIP: Start-Transcript Add option to minimise transcript header Start-Transcript Add option to minimise transcript header Dec 16, 2018
daxian-dbw
daxian-dbw requested changes Dec 19, 2018
View reviewed changes
daxian-dbw
daxian-dbw requested changes Dec 19, 2018
View reviewed changes
@daxian-dbw
Copy link
Member

daxian-dbw commented Dec 19, 2018 •
edited
Loading

@lukexjeremy On another thought, -UseShortHeader might be a better choice as you only have two options: the regular header and the short header, while minimal seems suggesting you have at least 3 options for the header. What do you think?

At the meantime, let me consult with the team members and reply back what they think. Chatted with my teammates offline, and there is a slight preference toward -UseMinimalHeader. So let's stick to that name 😄

@ghost ghost mentioned this pull request Dec 20, 2018
Closed
8 tasks
@daxian-dbw
Copy link
Member

daxian-dbw commented Dec 20, 2018

@lukexjeremy Thank you for opening the doc issue. I forgot that myself :)

@daxian-dbw daxian-dbw merged commit 56fc426 into PowerShell:master Dec 20, 2018
@sdwheeler sdwheeler mentioned this pull request Dec 21, 2018
Merged
9 tasks
@ghost ghost deleted the transcript-minimalheader branch December 21, 2018 22:45
@PaulHigin PaulHigin added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jan 24, 2019
@ghost ghost mentioned this pull request Apr 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmenaga anmenaga Awaiting requested review from anmenaga

@BrucePay BrucePay Awaiting requested review from BrucePay

Assignees

@daxian-dbw daxian-dbw

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iSazonov @daxian-dbw @PaulHigin @lukej57