WIP Use early preview of .Net Core 3.0 by bergmeister · Pull Request #8370 · PowerShell/PowerShell

bergmeister · 2018-11-30T12:37:19Z

PR Summary

There are only 1 failing test on Windows due to Compatibility section in application manifest not being embedded in pwsh.exe (https://github.com/dotnet/core-setup/issues/4963).

.Net Core 3.0 adds one reference assembly and also a .nupkg.metadata file for each shipped module containing the hash, which I ignore for the installer.

Removed dependency on rcedit to embed manifest and update assembly file properties as .Net Core 3.0 SDK supports same capabilities from csproj file. Due to this change, the fileversion and productversion embedded as rouces in pwsh.exe has changed to their desired format defined in the csproj. Tests were updated to account for this difference.

.Net Core 3.0 supports writing to reserved device names (like CON which writes to the console as expected; didn't test COM or LPT but presumably they would write to the COM and printer ports), so updated code to only check for CLOCK$ as a reserved device name.

Breaking Change By default, long paths are returned by the FileSystemProvider whereas before, it would retain the short path. This change is due to a change in .Net Core 3.0 behavior related to long paths which invalidated existing tests that used $TestDrive which is built from $env:TEMP which has a short path (if the username is > 8 characters which is the case on AzPipelines for Windows).

PR Checklist

… image creation process

…t (build number does not match sdk)

… to problems, they have stopped supporting it, therefore use dotnet test as an alternative xunit/xunit#1675 https://xunit.github.io/releases/2.4

…lease 2h ago

…o netcore2.2

…o netcore2.2 # Conflicts: # build.psm1 # test/hosting/hosting.tests.csproj

…t code

…o netcore2.2

…o netcore2.2 Conflicts auto-resolved by Tortoise-Git (white space problem only) # Conflicts: # assets/files.wxs

…o netcore2.2

…ccore and sos due to the upgrade from preview2 to preview3

…o netcore2.2

… not working with using netcore3.0

SteveL-MSFT · 2019-01-29T21:29:34Z

crossgen is returning exit code 139 on Linux and macOS which causes CI to fail. Created https://github.com/dotnet/coreclr/issues/22276

PowerShell.Common.props

…o netcore3.0 # Conflicts: # assets/files.wxs # build.psm1

…o netcore3.0 Mainly resolved by keeping the version of the branch due to the runtime update # Conflicts: # PowerShell.Common.props # assets/files.wxs # global.json # test/Test.Common.props # test/tools/WebListener/WebListener.csproj

SteveL-MSFT · 2019-02-21T05:57:29Z

Reverted attempt to move to newer 3.0 release since it caused more problems

bergmeister · 2019-03-08T05:52:00Z

We should try the new preview3 that got published yesterday

iSazonov · 2019-03-08T12:11:45Z

Since 6.2-GA was forked we can actively work on the PR.
I think we need rebase and then move to 3.0-Preview3.

bergmeister · 2019-03-08T12:56:32Z

I tried to update to preview3 locally but unless I made a mistake, I cannot even do a dotnet restore. It seems there are no matching Asp.Net Core Nuget packages. The version available on NuGet here is only version 3.0.0-preview3-19153-02 and does not match the requirements of projects depending on it. I get lots of errors similar to this:

C:\PowerShell\src\Microsoft.PowerShell.SDK\Microsoft.PowerShell.SDK.csproj : error NU1603: Microsoft.PowerShell.SDK depends on runtime.win-x64.Microsoft.AspNetCore.App (>= 3.0.0-preview3-27503-5) but runtime.win-x64.Microsoft.AspNetCore.App 3.0.0-preview3-27503-5 was not found. An approximate best match of runtime.win-x64.Microsoft.AspNetCore.App 3.0.0-preview4-19121-08 was resolved. [C:\PowerShell\src\powershell-win-core\powershell-win-core.csproj]
....
C:\PowerShell\src\powershell-win-core\powershell-win-core.csproj : error NU1603: pwsh depends on runtime.win-x64.Microsoft.AspNetCore.App (>= 3.0.0-preview3-27503-5) but runtime.win-x64.Microsoft.AspNetCore.App 3.0.0-preview3-27503-5 was not found. An approximate best match of runtime.win-x64.Microsoft.AspNetCore.App 3.0.0-preview4-19121-08 was resolved.

To me this looks like the Asp.Net Core Team needs to publish a newer preview3 version of their Microsoft.AspNetCore.App Nuget package to fulfill those requirements. Do you know more details @DamianEdwards ?
I pushed to a temporary branch here in this commit, the build here shows the same symptoms that I see locally.

iSazonov · 2019-03-08T14:15:31Z

I wonder how we depend on Microsoft.AspNetCore.App?

…o netcore3.0 # Conflicts: # assets/files.wxs

fMichaleczek · 2019-04-12T01:08:29Z

@bergmeister I try to compile your .net v3 branch and found the same symptom.

If I remove 'RuntimeFrameworkVersion' on PowerShell.Common.props and Test.Common.props , it lets me compile.

I also rollback your change to Microsoft.WindowsDesktop.App
branch:netcore3.0_preview3

dotnet.exe -info

.NET Core runtimes installed:
  Microsoft.AspNetCore.App 3.0.0-preview3-19153-02 [c:\program files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 3.0.0-preview3-27503-5 [c:\program files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 3.0.0-preview3-27504-2 [c:\program files\dotnet\shared\Microsoft.WindowsDesktop.App]

There is a version's conflict between all Microsoft.*.App runtimes and PowerShell.Common.props
I read all previous what's news about dotnet and aspnet, i don't found anything interesting.

bergmeister · 2019-04-12T06:36:18Z

@fMichaleczek At the moment we are waiting for preview4 to fix problems like that. If you want to try out a working version of netcore3 you could try using a daily build or checkout one of the older commits on this branch that used preview1 or preview2

SteveL-MSFT · 2019-04-18T20:45:59Z

Looks like Preview.4 just became available, I'll move the build to that version

SteveL-MSFT · 2019-04-19T01:23:43Z

Moving this to a working branch on PS/PS

bergmeister added 30 commits October 6, 2018 16:38

try upgrade to 2.2preview2 of .net core

b4687ad

fix version number of sdk (needs to include build number)

56ba0a1

[feature] set runtimeversion and revert changes made to alpine docker…

b961bc2

… image creation process

[feature] Fix NuGet package version of WebListener.csproj test projec…

04f8a7d

…t (build number does not match sdk)

[feature] Fix WiX file components due to newer versions of DLLS

3571629

trigger ci

0a61826

The dotnet-xunit test runner does not work with .Net Core 2.2 and due…

97a67be

… to problems, they have stopped supporting it, therefore use dotnet test as an alternative xunit/xunit#1675 https://xunit.github.io/releases/2.4

I forgot that trx format ix VsTest, not NUnit

9c48a7a

[feature]

91d1c82

[feature] Fix parameter name due to rename

17fab9b

[feature] revert to use xml test logger again

5750e86

[feature] forgot some folder->file reverts

b75514a

[feature] Update Markdig.Signed NuGet package to 0.15.4 due to new re…

e092441

…lease 2h ago

[feature] retrigger CI due to sporadic failure

699afb8

Merge branch 'master' of https://github.com/PowerShell/PowerShell int…

e8d76e2

…o netcore2.2

Merge branch 'master' of https://github.com/PowerShell/PowerShell int…

d4f2fa4

…o netcore2.2 # Conflicts: # build.psm1 # test/hosting/hosting.tests.csproj

fix merge conflict error to have no diff again in the upstreamed xuni…

7de084d

…t code

Merge branch 'master' of https://github.com/PowerShell/PowerShell int…

533b0e0

…o netcore2.2

Merge branch 'master' of https://github.com/PowerShell/PowerShell int…

96feacf

…o netcore2.2 Conflicts auto-resolved by Tortoise-Git (white space problem only) # Conflicts: # assets/files.wxs

Merge branch 'master' of https://github.com/PowerShell/PowerShell int…

faa0d19

…o netcore2.2

Update to .Net Core 2.2-preview3

fda3fb9

[feature] udpate test project version and appveyor cache

8a13d7c

[feature] Fix MSI installer by updating to the new version of mscorda…

52de7b7

…ccore and sos due to the upgrade from preview2 to preview3

Merge branch 'master' of https://github.com/PowerShell/PowerShell int…

580a5ca

…o netcore2.2

Upgrade to .Net Core 3.0.100-preview-009806 (latest master)

d6f499c

fix runtime version

0450437

fix installer and ignore nupkg info files

ede5bc6

[feature]

7d84226

update ResGen project to .Net Core 3.9 since 2.0 is deprecated and is…

f7e5127

… not working with using netcore3.0

[feature] upgrade typegen to .net core 3.0 as well and update comments

b50c906

[feature] move to .Net Core 3.0 preview 2

8f62ed8

[feature] fix case where typegen has an empty string in the file

8013cc6

iSazonov reviewed Jan 30, 2019

View reviewed changes

PowerShell.Common.props Show resolved Hide resolved

SteveL-MSFT mentioned this pull request Jan 30, 2019

.Net Core 3.0 compiler complains about #pragma warning enable xxxx when using C#7.3 dotnet/roslyn#32958

Closed

Merge branch 'master' of https://github.com/PowerShell/PowerShell int…

444bd46

…o netcore3.0 # Conflicts: # assets/files.wxs # build.psm1

iSazonov mentioned this pull request Feb 16, 2019

S.M.A.Language.Compiler doesn't work on .NET Core 3.0 #8880

Closed

SteveL-MSFT force-pushed the netcore3.0 branch from 5d91318 to 3528292 Compare February 21, 2019 05:56

Merge branch 'master' of https://github.com/PowerShell/PowerShell int…

0269ac2

…o netcore3.0 # Conflicts: # assets/files.wxs

PowerShell deleted a comment from PoshChan Mar 28, 2019

PowerShell deleted a comment from PoshChan-Staging Mar 28, 2019

SteveL-MSFT changed the base branch from master to netcore30 April 19, 2019 01:20

Merge branch 'netcore30' into netcore3.0

8090588

SteveL-MSFT merged commit a27e92b into PowerShell:netcore30 Apr 19, 2019

TravisEz13 added this to the 7.0.0-preview.1 milestone Apr 23, 2019

TravisEz13 added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Apr 23, 2019

SteveL-MSFT mentioned this pull request Jan 31, 2020

Cross fails with exit code 139 against PowerShell Core 6 assembly System.Management.Automation.dll dotnet/runtime#11925

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP Use early preview of .Net Core 3.0#8370

WIP Use early preview of .Net Core 3.0#8370
SteveL-MSFT merged 74 commits intoPowerShell:netcore30from
bergmeister:netcore3.0

bergmeister commented Nov 30, 2018 •

edited by SteveL-MSFT

Loading

Uh oh!

SteveL-MSFT commented Jan 29, 2019

Uh oh!

Uh oh!

SteveL-MSFT commented Feb 21, 2019

Uh oh!

bergmeister commented Mar 8, 2019

Uh oh!

iSazonov commented Mar 8, 2019

Uh oh!

bergmeister commented Mar 8, 2019 •

edited

Loading

Uh oh!

iSazonov commented Mar 8, 2019

Uh oh!

fMichaleczek commented Apr 12, 2019 •

edited

Loading

Uh oh!

bergmeister commented Apr 12, 2019

Uh oh!

SteveL-MSFT commented Apr 18, 2019

Uh oh!

SteveL-MSFT commented Apr 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

bergmeister commented Nov 30, 2018 • edited by SteveL-MSFT Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

SteveL-MSFT commented Jan 29, 2019

Uh oh!

Uh oh!

SteveL-MSFT commented Feb 21, 2019

Uh oh!

bergmeister commented Mar 8, 2019

Uh oh!

iSazonov commented Mar 8, 2019

Uh oh!

bergmeister commented Mar 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iSazonov commented Mar 8, 2019

Uh oh!

fMichaleczek commented Apr 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bergmeister commented Apr 12, 2019

Uh oh!

SteveL-MSFT commented Apr 18, 2019

Uh oh!

SteveL-MSFT commented Apr 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

bergmeister commented Nov 30, 2018 •

edited by SteveL-MSFT

Loading

bergmeister commented Mar 8, 2019 •

edited

Loading

fMichaleczek commented Apr 12, 2019 •

edited

Loading